[PATCH] x86-64: Implement strcpy family IFUNC selectors in C

[H.J. Lu]

On Mon, Jun 12, 2017 at 6:04 AM, Florian Weimer <fweimer@redhat.com> wrote:
> On 06/12/2017 01:33 AM, H.J. Lu wrote:
>
>> diff --git a/sysdeps/x86_64/multiarch/ifunc-unaligned-ssse3.h b/sysdeps/x86_64/multiarch/ifunc-unaligned-ssse3.h
>> new file mode 100644
>> index 0000000..5e7c47d
>> --- /dev/null
>> +++ b/sysdeps/x86_64/multiarch/ifunc-unaligned-ssse3.h
>
> I think we usually call such files *-skeleton.c these days, but I don't
> have a strong preference.

I will keep ifunc-*.h then.

>> +++ b/sysdeps/x86_64/multiarch/stpcpy-sse2.S
>
>> +# undef weak_alias
>> +# define weak_alias(__stpcpy, stpcpy)
>> +# undef libc_hidden_def
>> +# define libc_hidden_def(__stpcpy)
>> +# undef libc_hidden_builtin_def
>> +# define libc_hidden_builtin_def(stpcpy)
>
> I find this quite confusing.  Maybe use
>
> #define weak_alias(ignored1, ignored2)

Done.

> instead?  (And I'd really prefer this kind of preprocessor hackery
> wouldn't be necessary.
>
>> +++ b/sysdeps/x86_64/multiarch/stpcpy.c
>
>> +weak_alias (__stpcpy, stpcpy)
>> +__hidden_ver1 (__stpcpy, __GI___stpcpy, __redirect___stpcpy)
>> +  __attribute__((visibility ("hidden")));
>> +__hidden_ver1 (stpcpy, __GI_stpcpy, __redirect_stpcpy)
>> +  __attribute__((visibility ("hidden")));
>
> Missing space before parenthesis (after __attribute__).  This occurs
> five times in the patch.

Done.

Here is the patch I am testing now and I will check it shortly.

Thanks.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-x86-64-Implement-strcpy-family-IFUNC-selectors-in-C.patch
Type: text/x-patch
Size: 20297 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170612/020b4d07/attachment.bin>