[PATCH v3 2/2] float128: Add strfromf128, strtof128, and wcstof128 to the manual

Gabriel F. T. Gomes gftg@linux.vnet.ibm.com
Fri Jun 9 16:55:00 GMT 2017


On Thu, 8 Jun 2017 04:42:29 -0700
Rical Jasan <ricaljasan@pacific.net> wrote:

> Not that it matters, but @c tends to be used for these comments.  In
> light of the @errno and @standards work I've been doing, I wonder if
> that's a historical habit due to external processes utilizing @comments
> for various purposes...  but I like the shorter syntax anyway.
> 
> It looks like the strfrom's were a rare exception, which I'm guessing
> was the template (unseen here, directly above).

I tried to keep the existing style, which seems to be the use of
@comment, throughout the file.

> At any rate, "this function depends" should be "these functions depend",
> if the @safety annotation is true for both of them.  Some of the safety
> commentary gets pretty detailed too, so this might be improved by being
> more explicit about which function depends on what and where the safety
> issues lie; i.e., something like: "strfromfN depends on __printf_fp and
> strfromfNx depends on __printf_fphex, both of which are AS-unsafe
> (ascuheap) and AC-unsafe (acsmem)."  (I don't actually know if that's
> right, just inferring.)

I rewrote this phrase so that it is more clear that all strfrom*
functions depend on both __printf_fp and __printf_fphex.  That's what I
meant.  Could you check if the new wording is more clear, please?


I addressed all the comments in this thread and sent a new version of this
patch.  I am also learning how to contact the texinfo community, so that I
can comment about the use of @var{} in @deftypefun.  Thank you!



More information about the Libc-alpha mailing list