[PING][PATCH v2] Remove check for NULL buffer passed to `ptsname_r'

[Florian Weimer]

On 06/07/2017 03:39 PM, Zack Weinberg wrote:
>> `ptsname_r' is declared in stdlib.h to only accept a `nonnull'
>> second argument and therefore GCC may choose to make optimizations
>> based on the assumption that this argument is NULL. This means
>> that potentially, GCC can optimize away the NULL check at some
>> point in the future. Since this is a programming interface, we
>> might as well remove the NULL check ourselves.
>>
>> This also warrants a change to the `ptsname_r' manual page that
>> must be submitted to the corresponding mailing list.
> 
> Is this function documented in our manual (manual/*.texi)? If so,
> please update that.

Our manual doesn't say what happens with a NULL buffer, so no update is
needed.

> OK with that change.  I don't think we need a copyright assignment for
> a change that deletes seven lines of code and adds none.

Arjun's work is covered.

Thanks,
Florian