[PATCH] getaddrinfo: Always allocate canonical name on the heap

Florian Weimer fweimer@redhat.com
Sat Jun 3 06:40:00 GMT 2017


On 06/02/2017 11:26 PM, Joseph Myers wrote:
> I'm still seeing a localplt failure for strdup even after commit 
> 6257fcfd58479f6b7ae0fdde045b9ff144d543da.
> 
> https://sourceware.org/ml/libc-testresults/2017-q2/msg00276.html
> 
> (The strdup@plt reference is from gaih_inet.constprop.6, at least on 
> x86_64.  It seems there is one plain strdup reference in 
> sysdeps/posix/getaddrinfo.c.)

Right.  I figured out why I wasn't seeing this (localplt doesn't check
for local function relocation relocations in general, only PLT entries,
so -z blinds it), and verified that the attached patch fixes the
remaining failure.  Committed.

Thanks,
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: getaddrinfo-localplt-2.patch
Type: text/x-patch
Size: 642 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170603/6e8e0647/attachment.bin>


More information about the Libc-alpha mailing list