[PATCH 2/6] float128: Add conversion from float128 to mpn

Gabriel F. T. Gomes gftg@linux.vnet.ibm.com
Thu Jun 1 23:52:00 GMT 2017


On Thu, 1 Jun 2017 13:23:25 +0000
Joseph Myers <joseph@codesourcery.com> wrote:

> On Mon, 29 May 2017, Gabriel F. T. Gomes wrote:
> 
> > I attached a new patch which replaces the definition of MAX and MIN in
> > stdlib/gmp-impl.h with an inclusion of sys/param.h.
> > 
> > Is the attached patch OK for master?  
> 
> That patch is OK.

Thanks.  I've committed it.

> This sounds like an include ordering problem.  float128_private.h 
> redefines lots of names from math_private.h and math.h.  But that doesn't 
> cause problems because it includes those headers first.  So how about 
> making float128_private.h include gmp.h before redefining 
> __mpn_extract_long_double?

Thanks again.  I rewrote this and I'll send again with the other patches
in the series.



More information about the Libc-alpha mailing list