[ARM] Fix ld.so crash when built using Binutils 2.29

Phil Blundell pb@pbcl.net
Thu Jul 13 11:41:00 GMT 2017


On Wed, 2017-07-12 at 17:13 +0100, Jiong Wang wrote:
> 

> 2017-07-12  Jiong Wang  <jiong.wang@arm.com>
> 
>          * sysdeps/arm/dl-machine.h (elf_machine_load_address):  Also
> strip bit 0
>          of pcrel_address under Thumb mode.

It seems a bit unfortunate that the semantics of the ADR instruction
have changed in this way (after nearly two decades of the old
behaviour) but having reviewed the GAS bug report again I do agree with
Nick's rationale for doing that.  And this patch seems like a
reasonable way of dealing with it in glibc.  So, assuming you have
tested this with both old and new binutils, it is OK.

Thanks

Phil



More information about the Libc-alpha mailing list