[PATCH] Remove debug/stack_chk_fail_local.c [BZ #21740]

[Nick Alcock]

On 9 Jul 2017, H. J. Lu verbalised:

> Since
>
> commit 524a8ef2ad76af8ac049293d993a1856b0d888fb
> Author: Nick Alcock <nick.alcock@oracle.com>
> Date:   Mon Dec 26 10:08:57 2016 +0100
>
>     PLT avoidance for __stack_chk_fail [BZ #7065]
>
>     Add a hidden __stack_chk_fail_local alias to libc.so,
>     and make sure that on targets which use __stack_chk_fail,
>     this does not introduce a local PLT reference into libc.so.
>
> added
>
> strong_alias (__stack_chk_fail, __stack_chk_fail_local)
>
> to debug/stack_chk_fail.c, debug/stack_chk_fail_local.c should be
> removed.
>
> OK for master?

If it passes a test build with --enable-stack-protector=all without
pulling junk into ld.so and exploding at ld.so link time, sure. (That's
what happened every time I tried to remove this stuff before, but I may
have failed to notice that this may not be necessary any more.)

> -/* On some architectures, this helps needless PIC pointer setup
> -   that would be needed just for the __stack_chk_fail call.  */

Does anyone know what architectures these might be? Presumably x86-32...

-- 
NULL && (void)