[PATCHv2] Fix float128 IFUNC relocations on ppc64le [BZ #21707]

Florian Weimer fweimer@redhat.com
Sat Jul 8 19:17:00 GMT 2017


On 07/08/2017 08:31 PM, Tulio Magno Quites Machado Filho wrote:
> Changes since version 1:
> 
>  - Added a testcase.  This is now validating both statically and
>    dynamically linked executables.
>  - Fixed an issue in the $(foreach ..) in sysdeps/powerpc/powerpc64le/Makefile.
>  - Added a comment to csu/libc-start.c
>  - Added a comment to csu/libc-tls.c
> 
> -- 8< --
> 
> The patch proposed by Peter Bergner [1] to libgc in order to fix

Typo, should be “libgcc”.

> +__thread int bar;
> +static int * bar_ptr = NULL;

No space after “*”?

> +  else {
> +    printf ("FAIL: IFUNC resolver not called once.\n");
> +    ret = 1;
> +  }
> +
> +  if (&bar == bar_ptr)
> +    printf ("PASS: Address read from IFUNC resolver is correct.\n");
> +  else {
> +    printf ("FAIL: Address read from IFUNC resolver is incorrect.\n");
> +    ret = 1;
> +  }

The “{” should be on its own line.

Thanks,
Florian



More information about the Libc-alpha mailing list