[PATCH] resolv: Forward legacy name resolution function calls to NSS

[Carlos O'Donell]

On 07/04/2017 11:55 AM, Florian Weimer wrote:
> On 07/04/2017 05:47 PM, Carlos O'Donell wrote:
> 
>> Given that we have F27 about to freeze and release with 2.26, I think it
>> would be a good idea to wait for the release, put this patch into Rawhide,
>> and let it percolate to see if anything fails? Then come back and we can
>> put the patch into 2.27?
> 
> There is nothing in Fedora which uses these symbols.  nss_nis uses
> __nss_configure_lookup to break the loop.  Debian code search doesn't
> show any real users, either.  So I don't think this would give us any
> additional information.

OK, then I guess your changes can go in any time.

My only request would be:

* A larger comment explaining the limits of these functions and when
  and how they will fail. An NSS modules calling res_gethostbyname
  would not expect recursion into NSS, what happens in that case? Infinite
  recursion and a crash?

That way when someone debugs this down to these functions they have a useful
comment to look at, since they might be asking the question "Was recursion
ever considered?"

-- 
Cheers,
Carlos.