[PATCH v4] linux ttyname and ttyname_r: do not return wrong results

Christian Brauner christian.brauner@canonical.com
Tue Jan 31 10:57:00 GMT 2017


Appended to the mail you'll find a program that'll allow you to test the changes
to ttyname() and ttyname_r() on a patched glibc. Are we good about the patch as
it stands?

On Fri, Jan 27, 2017 at 03:59:58PM +0100, Christian Brauner wrote:
> Hi,
> 
> Last we've talked this patches was ready to merge. The only thing left to do was
> to sign an FSF agreement. I did and it is fully processed. If you need to see a
> PDF I can send it to a specific person privately per mail. I hope we're good to
> go now. :)
> 
> I've taken over this patch from Serge who has been informed and is CCed on this
> thread. There are no significant functional changes. As requested the following
> this have been changed:
> 
> - remove obsolete comment in ttyname_r.c
> - move is_pty() to common header file and mark as static inline
> 
> Christian
> 
> Christian Brauner (1):
>   linux ttyname and ttyname_r: do not return wrong results
> 
>  ChangeLog                           | 12 ++++++++++++
>  sysdeps/unix/sysv/linux/ttyname.c   | 16 ++++++++++++----
>  sysdeps/unix/sysv/linux/ttyname.h   | 35 +++++++++++++++++++++++++++++++++++
>  sysdeps/unix/sysv/linux/ttyname_r.c | 17 +++++++++++++----
>  4 files changed, 72 insertions(+), 8 deletions(-)
>  create mode 100644 sysdeps/unix/sysv/linux/ttyname.h
> 
> -- 
> 2.11.0
-------------- next part --------------
A non-text attachment was scrubbed...
Name: enodev_on_pty_in_different_namespace.c
Type: text/x-csrc
Size: 1826 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170131/297be5c0/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170131/297be5c0/attachment.sig>


More information about the Libc-alpha mailing list