[PATCH] Add new templates for IEEE wrappers
Joseph Myers
joseph@codesourcery.com
Mon Feb 20 23:14:00 GMT 2017
On Fri, 17 Feb 2017, Gabriel F. T. Gomes wrote:
> +#if defined __USE_WRAPPER_TEMPLATE && __USE_WRAPPER_TEMPLATE
I think throughout you should just use "#if __USE_WRAPPER_TEMPLATE", so
that not being defined is an error.
> diff --git a/math/w_lgamma_r_template.c b/math/w_lgamma_r_template.c
> + if (__glibc_unlikely (!isfinite (y)) && isfinite (x))
> + /* Overflow. */
Or pole error for negative integer arguments (inaccurate comment).
> diff --git a/math/w_lgamma_template.c b/math/w_lgamma_template.c
> + if (__glibc_unlikely (!isfinite (y)) && isfinite (x))
> + /* Overflow. */
Likewise.
> + else if (M_SUF (__floor) (x) == x && x < 0)
> + /* Domain error: tgamma(x<0). */
*integer* x < 0, not any x < 0 (inaccurate comment).
OK with those changes.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list