[PATCH] build-many-glibcs: don't crash if email is not configured
Joseph Myers
joseph@codesourcery.com
Thu Feb 16 22:20:00 GMT 2017
On Thu, 16 Feb 2017, Zack Weinberg wrote:
> The 'bot-cycle' action for build-many-glibcs is a convenient way to
> not have to remember all the steps in keeping a many-glibcs tree up
> to date ... or it would be, if the script could send mail _optionally_.
> Make it so by skipping the mail step if mail isn't configured.
>
> OK?
>
> * scripts/build-many-glibcs.py (bot_build_mail): If the
> bot_config does not contain all of the necessary email-
> related settings, just print a warning and continue.
I'm not sure what self.email_warning is for, given it's only set to True
right before the script exits (so will always be False when tested). OK
without that variable.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list