[PATCH] powerpc64: strrchr optimization for power8

Peter Bergner bergner@vnet.ibm.com
Mon Feb 13 16:18:00 GMT 2017


On 2/8/17 11:00 PM, Rajalakshmi Srinivasaraghavan wrote:

> +	/* r4 is changed now ,if its passed as more chars
> +	   check for null again */

Not sure without looking at the code closer, but should this
read like the following???

/* r4 is changed now.  If it's passed more chars, then check for
    null again.  */



> +	/* if there are more than one 0xff in r11, find the first pos of ff
> +	   in r11 and fill r10 with 0 from that position */

First word should be capitalized and there is no final '.' and two
spaces at the end of the sentence.  I would also write out position
rather than using "pos" like you did at the end of the sentence.


> +	vsl	v9, v8, v9	/* v9 = 0x4040404040404040. */

Two spaces after the '.'.

Peter





More information about the Libc-alpha mailing list