[PATCH 1/4] Consolidate Linux accept implementation

Phil Blundell pb@pbcl.net
Thu Feb 9 19:14:00 GMT 2017


On Wed, 2017-02-08 at 21:26 -0200, Adhemerval Zanella wrote:
> 
> And this snippet is indeed wrong as you pointed out, m68k (and any
> other
> architecture) just need to undef is for kernel < 4.3 as:
> 
> diff --git a/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> index 6811a28..0f31f86 100644
> --- a/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> +++ b/sysdeps/unix/sysv/linux/m68k/kernel-features.h
> @@ -27,7 +27,6 @@
>  # define __ASSUME_BIND_SYSCALL               1
>  # define __ASSUME_CONNECT_SYSCALL            1
>  # define __ASSUME_LISTEN_SYSCALL             1
> -# define __ASSUME_ACCEPT4_FOR_ACCEPT_SYSCALL 1
>  # define __ASSUME_GETSOCKOPT_SYSCALL         1
>  # define __ASSUME_SETSOCKOPT_SYSCALL         1
>  # define __ASSUME_GETSOCKNAME_SYSCALL        1
> @@ -42,6 +41,7 @@
>  #include_next <kernel-features.h>
> 
>  #if __LINUX_KERNEL_VERSION < 0x040300
> +# undef __ASSUME_ACCCEPT_SYSCALL
>  # undef __ASSUME_ACCEPT4_SYSCALL
>  # undef __ASSUME_RECVMMSG_SYSCALL
>  # undef __ASSUME_SENDMMSG_SYSCALL

Thanks, that makes sense.  I think you've still got too many "C"s in
"ACCEPT" in that last hunk above though.

p.



More information about the Libc-alpha mailing list