[PATCH v2 06/15] RISC-V: Generic <math.h> and soft-fp Routines

Palmer Dabbelt palmer@dabbelt.com
Sun Dec 24 00:24:00 GMT 2017


On Wed, 20 Dec 2017 08:50:48 PST (-0800), joseph@codesourcery.com wrote:
> On Tue, 19 Dec 2017, Palmer Dabbelt wrote:
>
>> +#ifndef __riscv_flen
>> +
>> +#define _FPU_RESERVED 0xffffffff
>
> Missing preprocessor indentation, "# define" etc. inside #if (except for
> the #if of a header's multiple-include guard).  Likewise generally in lots
> of places in this patch.
>
>> +#define _FCLASS_MINF     (1<<0)
>
> GNU style would use (1 << 0) with spaces around <<; likewise elsewhere in
> this patch.

OK, sorry about that.  I believe I've gotten all of both of these.



More information about the Libc-alpha mailing list