[PATCH v2 1/3] Cleanup __ieee754_sqrt(f/l)
Joseph Myers
joseph@codesourcery.com
Wed Dec 20 18:07:00 GMT 2017
On Wed, 20 Dec 2017, Wilco Dijkstra wrote:
> Build & test OK on AArch64.
I think the general design is right, but I also think this really needs a
build-many-glibcs.py test run (as do subsequent patches moving calls to
use sqrt/sqrtf/sqrtl directly) because of the high risk of
architecture-specific breakage.
(Direct calling of sqrtf128 with similar redirects to those for sqrt /
sqrtf / sqrtl is also appropriate: GCC 8 has it as a built-in function so
can inline calls with -fno-math-errno on powerpc64le for POWER9. So the
patch should include a sqrtf128 redirect if __HAVE_DISTINCT_FLOAT128.)
> diff --git a/math/w_sqrt_template.c b/math/w_sqrt_template.c
> index 5fae302382d10e9b05df2665c9cb05126cd62f02..235c263e60c85422e41bca7c817148b66030438f 100644
> --- a/math/w_sqrt_template.c
> +++ b/math/w_sqrt_template.c
> @@ -21,6 +21,7 @@
> for each floating-point type. */
> #if __USE_WRAPPER_TEMPLATE
>
> +#define NO_SQRT_REDIRECT
Missing preprocessor indentation, "# define".
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list