[PATCH v2 02/15] RISC-V: ABI Implementation

[Joseph Myers]

On Tue, 19 Dec 2017, Palmer Dabbelt wrote:

> +END(__longjmp)

Should have space before '(' in such a macro call.

> +ENTRY(_dl_runtime_resolve)

Likewise.

> +END(_dl_runtime_resolve)

Likewise.  Please check and fix this throughout this patch series.

> +/*
> + * Macros to handle different pointer/register sizes for 32/64-bit code
> + */

GNU-style macros should not have the leading '*' on each line; please fix 
throughout this file and anywhere else affected in this patch series.  
Also, comments on macros or functions should generally not name the macro 
or function being described, so e.g. "Declare leaf routine." (or "Declare 
leaf routine SYMBOL.") not "LEAF - declare leaf routine".

> +	     : "=r"(__result));				\

Missing space before '(', and similarly in other TLS macros.

> +	__tls_get_addr(__result); })

Likewise, and similarly in other TLS macros.

-- 
Joseph S. Myers
joseph@codesourcery.com