[PATCH] Linux/x86: Support shadow stack pointer in setjmp/longjmp

Joseph Myers joseph@codesourcery.com
Tue Dec 19 18:33:00 GMT 2017


On Tue, 19 Dec 2017, H.J. Lu wrote:

> > I don't think you have consensus. You haven't answered most of
> > Joseph's questions, and it is not clear to me whether Florian
> > considers his objection resolved.  This is not a high-priority bugfix.
> 
> I have answered all questions.   Please show one question which I haven't
> answered.

I don't think you've adequately justified having OS-specific versions of 
all the setjmp/longjmp files, as opposed to having e.g. defined __SHSTK__ 
&& defined SHADOW_STACK_POINTER_OFFSET && defined FEATURE_1_OFFSET 
conditionals in the OS-independent files (which looks more like the actual 
condition that should be relevant here).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list