[PATCH] elf: Count components of the expanded path in _dl_init_path [BZ #22607]
Florian Weimer
fweimer@redhat.com
Thu Dec 14 14:08:00 GMT 2017
On 12/14/2017 02:58 PM, Andreas Schwab wrote:
> On Dez 14 2017, Florian Weimer <fweimer@redhat.com> wrote:
>
>> On 12/14/2017 02:45 PM, Andreas Schwab wrote:
>>> On Dez 14 2017, fweimer@redhat.com (Florian Weimer) wrote:
>>>
>>>> + {
>>>> + const char *cp = llp_tmp;
>>>> + while (*cp)
>>>> + {
>>>> + if (*cp == ':' || *cp == ';')
>>>> + ++nllp;
>>>> + ++cp;
>>>> + }
>>>> + }
>>>
>>> No need for the outermost braces.
>>
>> I included them to limit the scope of cp, to make sure that there aren't
>> any uses afterwards because of the changed value of cp compared to the
>> original code.
>
> Since it is obviously unused afterwards I don't see any value for that.
What about this? It follows Dmitry's suggestion to use a for loop.
Thanks,
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llp.patch
Type: text/x-patch
Size: 1782 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20171214/e7979b5b/attachment.bin>
More information about the Libc-alpha
mailing list