[PATCHv2] powerpc: POWER8 memcpy optimization for cached memory

Adhemerval Zanella adhemerval.zanella@linaro.org
Mon Dec 11 20:09:00 GMT 2017



On 11/12/2017 10:44, Tulio Magno Quites Machado Filho wrote:
> Florian Weimer <fweimer@redhat.com> writes:
> 
>> On 12/08/2017 08:40 PM, Tulio Magno Quites Machado Filho wrote:
>>> +@deftp Tunable glibc.tune.cached_memopt
>>> +The @code{glibc.tune.cached_memopt=[0|1]} tunable allows the user to enable
>>> +optimizations recommended to cacheable memory.
>>> +
>>> +This tunable is specific to powerpc, powerpc64 and powerpc64le.
>>> +@end deftp
>>
>> I think this has a slight grammar problem.
>>
>> What about this instead?
>>
>> The @code{glibc.tune.cached_memopt=[0|1]} tunable allows the user to 
>> enable optimizations recommended for cacheable memory.  If set to 
>> @code{1}, @theglibc{} assumes that the process memory image consists of 
>> cacheable (non-device) memory only.  The default, @code{0}, indicates 
>> that the process may use device memory.
> 
> And a much better description.
> 
>> (I think it's best not to mention string functions here because it is 
>> impossible to describe how glibc.tune.cached_memopt affects them due to 
>> compiler optimizations.)
> 
> Ack.
> 
> Fixed locally.
> 
> Thanks!
> 

Thanks for working on this Tulio, LGTM.



More information about the Libc-alpha mailing list