[PATCH] Improves __ieee754_exp() performance by greater than 5x on sparc/x86.

Joseph Myers joseph@codesourcery.com
Tue Dec 5 23:20:00 GMT 2017


On Mon, 4 Dec 2017, Patrick McGehearty wrote:

> +/* ln2_32hi2 = high 32 bits of log(1./2.)/2. */
> +  ln2_32hi2 = 0x1.62e42fee00000p-7, 
> +/* ln2_32lo2 = low 32 bits of log(1./2.)/2. */
> +  ln2_32lo2 = 0x1.a39ef35793c76p-39,

Those comments aren't accurate descriptions.  In this patch version these 
have changed to be high and low parts of log(2)/64, so the comments should 
reflect that - and the name should be changed to say 64 not 32 and the 
users updated accordingly.  Furthermore, the low part isn't just a low 32 
bits, it has more than that, so again the comment should reflect that.

OK with those fixes.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list