[PATCH] posix: if glob has a trailing slash match directories only.

Paul Eggert eggert@cs.ucla.edu
Mon Dec 4 08:01:00 GMT 2017


Dmitry Goncharov wrote:
>>       flags |= GLOB_ONLYDIR | GLOB_MARK;
>>
>> and then at the end, filter out all matches that aren't marked with
>> trailing '/'. This would avoid creating a new GLOB_XXX option and would
>> probably be easier to implement.
>>
> Please have a look at this implementation of your idea.

I'm not quite following how it's an implementation, since I don't see where it 
does anything like "flags |= GLOB_ONLYDIR | GLOB_MARK;". Maybe there's another 
part of the patch you're missing?

The variable "filter" is a boolean and should be of type bool.

That comment and code look over-complicated. Can't you simply copy nonnull 
entries in-place, in a single pass? That way, the filtered order will be the 
same as the original order.



More information about the Libc-alpha mailing list