[RFC][PATCH] fix math cflags overrides

Szabolcs Nagy szabolcs.nagy@arm.com
Thu Aug 24 09:27:00 GMT 2017


The problem i see is that in the makefile logic the sysdirs var has
sysdeps/aarch64/fpu before sysdeps/ieee754/dbl-64.

this means source files and rules in the former override files in
the later (which is good), but it also means variable definitions
in makefile fragments of the later overrides the ones of the former
(i.e. reverse order wrt the source override, which is not what i'd
expect).

as a workaround i'd just use += instead of = in the dbl-64 makefile
cflags definitions so at least it does not drop earlier cflags,
the cflag definition ordering is not ideal: if i have a target
specific sqrt, i don't want to compile it with nofma flags.

2017-08-23  Szabolcs Nagy  <szabolcs.nagy@arm.com>

	* sysdeps/ieee754/dbl-64/Makefile: Don't override cflags.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: foo.diff
Type: text/x-patch
Size: 543 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170824/1244cca0/attachment.bin>


More information about the Libc-alpha mailing list