[PATCH 1/2] Mark internal argz functions with attribute_hidden [BZ #18822]

[H.J. Lu]

On Fri, Aug 18, 2017 at 8:50 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Fri, 18 Aug 2017, H.J. Lu wrote:
>
>> > In this case, the problem presumably is that the internal declarations are
>> > in the installed argz.h header.  So move them from the installed header to
>> > the include/ one.  At that point, using typeof *does* make sense to copy
>> > the type from the public function, e.g.
>> >
>> > extern __typeof (argz_add) __argz_add __THROW attribute_hidden;
>> >
>> > (argz.h is shared with gnulib, but in gnulib it doesn't have those
>> > internal declarations anyway.  So moving them to the include/ header helps
>> > bring the public one closer to the gnulib version.)
>> >
>>
>> Done.
>>
>> Here is the updated patch.  OK for master?
>
> __argz_replace was not previously __THROW, and neither is argz_replace.
> If you have done an analysis that establishes that use of __THROW is safe
> there, it should be added to argz_replace rather than just to the internal
> declaration.

Here is the updated patch with __THROW removed from __argz_replace.
OK for master?

Thanks.


-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Mark-internal-argz-functions-with-attribute_hidden-B.patch
Type: text/x-patch
Size: 6320 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170818/d7c4060c/attachment.bin>