[PATCH 2/4] Mark __internal_statvfs[64] with attribute_hidden [BZ #18822]

[H.J. Lu]

On Fri, Aug 18, 2017 at 6:24 AM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
>
>
> On 18/08/2017 10:19, Florian Weimer wrote:
>> On 08/18/2017 03:15 PM, H.J. Lu wrote:
>>> On Fri, Aug 18, 2017 at 5:55 AM, Florian Weimer <fweimer@redhat.com> wrote:
>>>> On 08/17/2017 10:58 PM, H.J. Lu wrote:
>>>>> Mark __internal_statvfs[64] with attribute_hidden to allow direct access
>>>>> to them within libc.so and libc.a without using GOT nor PLT.
>>>>>
>>>>> Tested on i686 and x86-64.  OK for master?
>>>>
>>>> This is a bit odd because the include/ headers are supposed to be
>>>> generic, and the declarations you add are Linux-specific.  In the past,
>>>> we would have added a Linux-specific header under
>>>> sysdeps/unix/sysv/linux for that.
>>>>
>>>> I don't have a strong opinion either way.
>>>>
>>>
>>> Header files under include override both generic and non-generic header
>>> files.  __KERNEL_STRICT_NAMES is another example.
>>
>> Right.  I'm sure your patch works as intended (at least on most
>> architectures).  It's just a matter of policy to what extent we want to
>> uphold the fiction that upstream glibc supports more than just Linux.
>
> I also think it should be on a Linux only header, mostly for organization.

Here is the updated patch with a new header file,

sysdeps/unix/sysv/linux/internal_statvfs.h

OK for master?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Mark-__internal_statvfs-64-with-attribute_hidden-BZ-.patch
Type: text/x-patch
Size: 5657 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170818/26893b4b/attachment.bin>