[PATCH] malloc: Abort on heap corruption, without a backtrace [BZ #21754]
Paul Eggert
eggert@cs.ucla.edu
Fri Aug 18 15:29:00 GMT 2017
Thanks, I like the overall change too. One quibble:
> + __libc_message (do_abort, "Fatal glibc error in malloc: %s\n", str);
This change to the message wording won't work well, as the user will see
redundant text like "Fatal glibc error in malloc: malloc(): memory corruption
(fast)". Also, the wording "glibc error" suggests that there must be a fault in
glibc, whereas it's more likely that the fault is in the application. I suggest
changing the above line to:
__libc_message (do_abort, "%s\n", str);
This is simpler, and this way glibc will keep using the same wording that it's
been using for a while.
More information about the Libc-alpha
mailing list