[PATCH 2/4] Mark __internal_statvfs[64] with attribute_hidden [BZ #18822]
Florian Weimer
fweimer@redhat.com
Fri Aug 18 12:55:00 GMT 2017
On 08/17/2017 10:58 PM, H.J. Lu wrote:
> Mark __internal_statvfs[64] with attribute_hidden to allow direct access
> to them within libc.so and libc.a without using GOT nor PLT.
>
> Tested on i686 and x86-64. OK for master?
This is a bit odd because the include/ headers are supposed to be
generic, and the declarations you add are Linux-specific. In the past,
we would have added a Linux-specific header under
sysdeps/unix/sysv/linux for that.
I don't have a strong opinion either way.
Thanks,
Florian
More information about the Libc-alpha
mailing list