[PATCH] Test for profiling support (_mcount/gprof)

[Florian Weimer]

On 08/15/2017 02:56 PM, Andreas Schwab wrote:
> On Aug 15 2017, Florian Weimer <fweimer@redhat.com> wrote:
> 
>> On 08/15/2017 02:28 PM, Andreas Schwab wrote:
>>> On Aug 15 2017, Florian Weimer <fweimer@redhat.com> wrote:
>>>
>>>> diff --git a/Makeconfig b/Makeconfig
>>>> index 80aed2a987..19b559701a 100644
>>>> --- a/Makeconfig
>>>> +++ b/Makeconfig
>>>> @@ -465,7 +465,8 @@ else  # not build-pie-default
>>>>  +link-before-libc = $(CC) -nostdlib -nostartfiles -o $@ \
>>>>  	      $(sysdep-LDFLAGS) $(LDFLAGS) $(LDFLAGS-$(@F)) \
>>>>  	      $(combreloc-LDFLAGS) $(relro-LDFLAGS) $(hashstyle-LDFLAGS) \
>>>> -	      $(addprefix $(csu-objpfx),$(start-installed-name)) \
>>>> +	      $(or $(CRT-$(@F)), $ \
>>>> +		$(addprefix $(csu-objpfx),$(start-installed-name))) \
>>>
>>> $(or) is a 3.81 feature, we only require 3.79.  You can use $(firstword)
>>> instead.
>>
>> Oh, good point.  $(firstword …) does not really align with the
>> subsequent $(addprefix …) usage because that has the implication that
>> $(start-installed-name) contains multiple words.
> 
> Other uses already require $(start-installed-name) to be a single word.
> A lot of places use addprefix when not really needed.

Okay.  What about the attached patch?  It uses $(firstword …) without
the comma.

Thanks,
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gmon-2.patch
Type: text/x-patch
Size: 6851 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170815/122a8ec0/attachment.bin>