internal_function symbols part of the public ABI

[Florian Weimer]

On 08/14/2017 04:37 PM, Andreas Schwab wrote:
> On Aug 14 2017, Florian Weimer <fweimer@redhat.com> wrote:
> 
>> The 2007 commit radically changed the calling convention, so it's safe
>> to assume that there were no active users on i386 at the time because
>> they would have run into crashes.  Today, it's still difficult to call
>> these functions because it is hard to write a correct prototype.
> 
> They are really private interfaces for nscd, AFAICS.
> 
>> Can we remove the functions completely?
> 
> They should be unexported, for sure.  Since nscd doesn't use them any
> more, they could just be dummies.

What about the attached patch?

I cleaned up the declarations of the __nss_*_lookup* functions.  They
are now generated from databases.def in <nsswitch.h>.  I switched all
the internal users of the *lookup functions to *lookup2 functions, so
that the compat functions are not used internally anymore.

Thanks,
Florian
-------------- next part --------------
A non-text attachment was scrubbed...
Name: compat-lookup.patch
Type: text/x-patch
Size: 12885 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20170814/21364538/attachment.bin>