[PATCH] _dl_init: Remove internal_function attribute

Florian Weimer fweimer@redhat.com
Mon Aug 14 12:39:00 GMT 2017


On 08/14/2017 02:28 PM, H.J. Lu wrote:
>>         # Clear %ebp, so that even constructors have terminated backchain.\n\
>>         xorl %ebp, %ebp\n\

> CFI adjustments are missing.

The original code did not have any because we never unwind to this
frame, as indicated by the zero %ebp value.

I can add CFI annotations for completeness, but I'd consider that  a
separate change.  It is also not quite clear to me what the canonical
frame address for the startup function should be.  We reach into the
caller's stack frame, after all.

Thanks,
Florian



More information about the Libc-alpha mailing list