[PATCH] _dl_fini: Remove internal_function attribute

H.J. Lu hjl.tools@gmail.com
Mon Aug 14 12:27:00 GMT 2017


On Mon, Aug 14, 2017 at 3:29 AM, Florian Weimer <fweimer@redhat.com> wrote:
> Assembler code passes the address of _dl_fini to __libc_start_main,
> whose function pointer argument lacks the attribute.  This means
> that calls could use the wrong ABI.  Fortunately, for zero-parameter
> void-returning functions, internal_function does not change ABI
> on i386 (the only architecture which uses internal_function), so
> this inconsistency was harmless (which is why it had not been
> noticed so far).
>
> 2017-08-14  Florian Weimer  <fweimer@redhat.com>
>
>         * elf/dl-fini.c (_dl_fini): Remove internal_function
>         * sysdeps/generic/ldsodefs.h (_dl_fini): Likewise.
>
>

LGTM.

Thanks.

-- 
H.J.



More information about the Libc-alpha mailing list