[PATCH] Define missing __inet6_scopeid_pton internal function used by getaddrinfo

Samuel Thibault samuel.thibault@ens-lyon.org
Thu Aug 10 13:31:00 GMT 2017


Florian Weimer, on jeu. 10 août 2017 15:28:05 +0200, wrote:
> On 08/03/2017 12:28 PM, Florian Weimer wrote:
> > __inet6_scopeid_pton: Remove attribute_hidden, internal_function
> > 
> > The hidden attribute was overridden by libc_hidden_proto on GNU/Linux.
> > It is incorrect because the function is used from nscd.
> > 
> > internal_function is not supposed to be used across DSO boundaries,
> > so this commit removes it (again, due to the use in nscd).
> > 
> > 2017-08-03  Florian Weimer  <fweimer@redhat.com>
> > 
> > 	* inet/net-internal.h (__inet6_scopeid_pton): Remove
> > 	attribute_hidden, internal_function.
> > 	* inet/inet6_scopeid_pton.c (__inet6_scopeid_pton): Remove
> > 	internal_function.
> 
> Any comments/  Otherwise I'm going to commit this shortly.

It's fine to me, and a simpler fix than mine :)

Samuel



More information about the Libc-alpha mailing list