[PATCH 4/4] posix: Implement preadv2 and pwritev2

Adhemerval Zanella adhemerval.zanella@linaro.org
Fri Apr 28 16:18:00 GMT 2017



> On 28 Apr 2017, at 11:53, Joseph Myers <joseph@codesourcery.com> wrote:
> 
>> On Fri, 28 Apr 2017, Adhemerval Zanella wrote:
>> 
>> My objection to __ASSUME_* is it adds more different possible build modes
>> which won't get actively tested unless you explicit adds a minimum kernel
>> option on build time.  And which different __ASSUME_* enabled by different
>> kernel version it would require different build with multiple different
>> enabled minimum kernel version to get all the coverage to check for all
>> permutations.  I think we can add an explicit comment and keep track based
>> on this, since with minimum kernel increase it will be eventually dead code.
> 
> Well, such comments would all need to be in a central place (e.g. 
> kernel-features.h) identifying the relevant versions, not scattered across 
> the source tree.

Right, I will add one on kernel-features.h with the information which kernel version is suppose to have preadv2 support (and any architecture difference as well).


More information about the Libc-alpha mailing list