[PATCH] SYSCALL_CANCEL: reduce the size of generated code

Florian Weimer fweimer@redhat.com
Sat Apr 15 07:38:00 GMT 2017


On 04/14/2017 10:07 PM, Yury Norov wrote:
> SYSCALL_CANCEL() currently calls INLINE_SYSCALL_CALL() both in true and
> false branches of the "if (SINGLE_THREAD_P)" condition. If arguments that
> passed in INLINE_SYSCALL_CALL() are wrapped with tricky macros or require
> other additional handling, the code that does it becomes duplicated, and
> it may increase the size of function that use it significantly.

It also widens the window for the race, so I'm not sure if this is a 
good idea.

I think this code will change with the cancellation fixes anyway.

Thanks,
Florian



More information about the Libc-alpha mailing list