[Patch] aarch64: Thunderx specific memcpy and memmove

Steve Ellcey sellcey@caviumnetworks.com
Thu Apr 6 20:48:00 GMT 2017


On Sat, 2017-04-01 at 21:01 -0300, Wainer dos Santos Moschetta wrote:
> In sysdeps/aarch64/multiarch/memcpy_generic.S, it has:
> +#include "../memcpy.S"
> 
> Is it ok to use relative path here? or rather it's recommended use of
> the full path since sysdeps?

I think its OK.  I don't see any preference listed in the Coding Style
page of the glibc wiki for one way or the other.  I see other includes
of relative paths, the most common one is '#include "../test-
skeleton.c"' but I also see other examples:

sysdeps/sparc/sparc64/multiarch/rtld-memset.c:#include "../rtld-memset.c"
sysdeps/sparc/sparc64/multiarch/rtld-memcpy.c:#include "../rtld-memcpy.c"
sysdeps/wordsize-64/ftw.c:#include "../../io/ftw.c"
sysdeps/wordsize-64/fts.c:#include "../../io/fts.c"
sysdeps/unix/sysv/linux/sparc/sparc64/xstat.c:#include "../../i386/xstat.c"
sysdeps/unix/sysv/linux/sparc/sparc64/fxstat.c:#include "../../i386/fxstat.c"
sysdeps/unix/sysv/linux/sparc/sparc64/fxstatat.c:#include "../../i386/fxstatat.c"
sysdeps/unix/sysv/linux/sparc/sparc64/lxstat.c:#include "../../i386/lxstat.c"
sysdeps/unix/sysv/linux/aarch64/readelflib.c:#include "../arm/readelflib.c"
sysdeps/unix/sysv/linux/wordsize-64/statvfs.c:#include "../statvfs.c"
sysdeps/unix/sysv/linux/wordsize-64/getdirentries.c:#include "../getdirentries.c"
sysdeps/unix/sysv/linux/wordsize-64/fstatvfs.c:#include "../fstatvfs.c"
sysdeps/unix/sysv/linux/wordsize-64/aio_write.c:#include "../../../../pthread/aio_write.c"
sysdeps/unix/sysv/linux/wordsize-64/openat.c:#include "../openat.c"

That seems more common than using:

sysdeps/unix/sysv/linux/s390/s390-32/updwtmp.c:#include "sysdeps/gnu/updwtmp.c"
sysdeps/unix/sysv/linux/s390/s390-32/getutmp.c:#include "sysdeps/gnu/getutmp.c"
sysdeps/x86_64/fpu/e_sqrtl.c:#include "sysdeps/i386/fpu/e_sqrtl.c"
sysdeps/x86_64/fpu/e_atan2l.c:#include "sysdeps/i386/fpu/e_atan2l.c"
sysdeps/x86_64/fpu/s_atanl.c:#include "sysdeps/i386/fpu/s_atanl.c"
sysdeps/x86_64/fpu/e_acosl.c:#include "sysdeps/i386/fpu/e_acosl.c"

Steve Ellcey



More information about the Libc-alpha mailing list