[PATCH v3] Add page tests to string/test-strnlen.
Tulio Magno Quites Machado Filho
tuliom@linux.vnet.ibm.com
Wed Apr 5 14:52:00 GMT 2017
Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com> writes:
> May be tricky for otimized implementations to handle strings around
> page boundary once, for instance, it is performed unaligned loads or
> when maxlen is used as a hint for vectorized loops. The test cases
> should unveil regression bugs on these cases.
>
> To some extend do_random_tests in string/test-strnlen tests strings
> placed at page end but it does not cover all cases. So this change
> adds tests which consists of placing strings of varying sizes ending
> at the page boundary. It also combines with different values of maxlen.
>
> Tested on ppc64le and x86_64.
>
> 2017-03-31 Wainer dos Santos Moschetta <wainersm@linux.vnet.ibm.com>
>
> * string/test-strnlen.c (do_page_tests): New function
> to check length of strings ending at the page boundary.
> (test_main): Added call to the do_page_tests function.
LGTM too.
Pushed as ff65c87.
--
Tulio Magno
More information about the Libc-alpha
mailing list