[PATCH] S390: Clobber also r14 in TLS_LD, TLS_GD macros on 31bit.

Stefan Liebler stli@linux.vnet.ibm.com
Tue Apr 4 11:19:00 GMT 2017


On 04/03/2017 03:50 PM, Stefan Liebler wrote:
> On 03/29/2017 11:22 AM, Stefan Liebler wrote:
>> Hi,
>>
>> This patch also clobbers r14 in TLS_LD, TLS_GD macros on 31bit.
>> This ensures that r14 isn't used to save and restore r12 while
>> r14 is clobbered by the bas-instruction.
>>
>> As note:
>> r12 can't be clobbered as gcc would fail with:
>> error: PIC register clobbered by ‘12’ in ‘asm’
>>
>> For 64bit this fix was already done in 2004 in the
>> commit b80af23ac6973e69df6cd23d221fa44fffb21e17.
>>
>> Bye
>> Stefan
>>
>> ChangeLog:
>>
>>     * sysdeps/s390/s390-32/tls-macros.h (TLS_LD, TLS_GD):
>>     Clobber also r14.
>
> Any objection?
> Otherwise, I'll commit it tomorrow.
>
> Bye
> Stefan
>
Committed.



More information about the Libc-alpha mailing list