[PATCH 10/13] Installed-header hygiene (BZ#20366): struct ether_addr.

Carlos O'Donell carlos@redhat.com
Wed Sep 21 19:51:00 GMT 2016


On 08/29/2016 09:16 PM, Zack Weinberg wrote:
> Some versions of netinet/if_ether.h only define struct ether_addr when
> __USE_MISC.  This breaks function prototypes in netinet/ether.h that
> depend on it.  The path of least resistance is to condition those
> declarations on __USE_MISC too.
> 
> 	* inet/netinet/if_ether.h: Condition all function prototypes
>         on __USE_MISC, to ensure struct ether_addr is declared.

Wrong ChangeLog path?

LGTM.

Linux does define an if_ether.h, but it uses struct ethhdr instead which
doesn't conflict.

-- 
Cheers,
Carlos.



More information about the Libc-alpha mailing list