[PATCH] Add test case for O_TMPFILE handling in open, openat

[Florian Weimer]

On 09/21/2016 01:53 PM, Florian Weimer wrote:
> On 09/20/2016 09:26 PM, Carlos O'Donell wrote:
>> On 09/20/2016 02:51 PM, Florian Weimer wrote:
>>> I noticed that we do not seem to have a test case for O_TMPFILE
>>> handling.
>>>
>>> I have tested the attached patch with recent kernels and Red Hat's
>>> 3.10 kernels (where it prints UNSUPPORTED).  I verified that
>>> probe_path works as intended with a vfat file system (which does not
>>> support O_TMPFILE even on a supported kernel).
>>
>> The actual details of the patch look good to me, so OK conditional
>> on more comments about:
>> * What is being tested.
>> * Is it sufficient?
>>   * If not, where might we improve in the future?
>> * Under what conditions do we mark as UNSUPPORTED?
>
> I tried to add a test for linkat, but it appears to be broken at the
> kernel level:
>
>   <http://marc.info/?l=linux-man&m=147445864822403&w=2>
>
> I'll probably commit the glibc test without the linkat bits.

And here is what I've committed.

Thanks,
Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmpfile.patch
Type: text/x-patch
Size: 8325 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160921/9220a2c9/attachment.bin>