[PATCH] Make ldexpF generic.
Paul E. Murphy
murphyp@linux.vnet.ibm.com
Wed Sep 14 16:31:00 GMT 2016
On 09/13/2016 05:56 PM, Joseph Myers wrote:
> On Tue, 13 Sep 2016, Paul E. Murphy wrote:
>
>> This one is a little more tricky since it is built both for
>> libm and libc, and exports multiple aliases.
>>
>> To simplify aliasing, a new macro is introduced which handles
>> aliasing to two symbols. By default, it just applies
>> declare_mgen_alias to both target symbols.
>>
>> Likewise, the makefile is tweaked a little to generate
>> templates for shared files too, and a new rule is added
>> to build m_*.c objects from the objpfx directory.
>
> Could you describe the testing done, in particular the configurations for
> which you've confirmed unchanged code generation for the relevant objects?
I'd manually checked the symbols and text sections. Which, as usual,
turns out to be error prone. I put this against the same set of
automated tests as the other generated patches (including both m_*
and s_* objects). This is missing the second alias for scalbn on
NO_LONG_DOUBLE machines.
Likewise, I used the s_catan* objects to verify removing the
redundant macro definition does not alter generation.
Attached is an updated patch. The only substantial change is adding
an extra weak alias for to2 for the new macro when building on a
NO_LONG_DOUBLE machine. It has been verified on multiple platforms
as described in the amended log.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Make-ldexpF-generic.patch
Type: text/x-patch
Size: 13774 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160914/e9900c01/attachment.bin>
More information about the Libc-alpha
mailing list