[PATCH] fxstatat: fix __fxstatat64 symbol generation
Andreas Schwab
schwab@linux-m68k.org
Fri Sep 9 15:29:00 GMT 2016
On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
> On Fri, Sep 09, 2016 at 04:16:44PM +0200, Andreas Schwab wrote:
>> On Sep 09 2016, Yury Norov <ynorov@caviumnetworks.com> wrote:
>>
>> > diff --git a/sysdeps/unix/sysv/linux/fxstatat.c b/sysdeps/unix/sysv/linux/fxstatat.c
>> > index f716bf3..32959e5 100644
>> > --- a/sysdeps/unix/sysv/linux/fxstatat.c
>> > +++ b/sysdeps/unix/sysv/linux/fxstatat.c
>> > @@ -61,5 +61,5 @@ libc_hidden_def (__fxstatat)
>> > #ifdef XSTAT_IS_XSTAT64
>> > # undef __fxstatat64
>> > strong_alias (__fxstatat, __fxstatat64);
>> > -libc_hidden_def (__fxstatat64)
>> > +libc_hidden_ver (__fxstatat, __fxstatat64)
>>
>> libc_hidden_ver doesn't make sense, as __fxstatat64 isn't a versioned
>> symbol. The real problem is that the hidden_proto for __fxstatat64 is
>> suppressed.
>>
>> Andreas.
>
> Maybe. I'm not too experienced in glibc versioning. And what the
> correct fix for it?
Reinstate the hidden_proto, but with a non-conflicting definition.
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
More information about the Libc-alpha
mailing list