[PATCH v3] getrandom system call wrapper [BZ #17252]

[Florian Weimer]

On 09/08/2016 03:36 PM, Andreas Schwab wrote:
> On Sep 08 2016, Florian Weimer <fweimer@redhat.com> wrote:
>
>> On 09/08/2016 03:19 PM, Andreas Schwab wrote:
>>> On Sep 08 2016, Florian Weimer <fweimer@redhat.com> wrote:
>>>
>>>> On 09/08/2016 03:01 PM, Andreas Schwab wrote:
>>>>> On Sep 08 2016, Florian Weimer <fweimer@redhat.com> wrote:
>>>>>
>>>>>> I have retained the __getrandom symbol mangling.  The justification for
>>>>>> that is that getrandom is a fairly common name.  Application code might
>>>>>> use it for something else entirely and interpose their definition, so that
>>>>>> libraries cannot rely on it doing the right thing.  I think the mangling
>>>>>> is justified because it is hard to spot that getrandom is broken due to
>>>>>> interposition.  As <sys/random.h> is a new header, the macro will be
>>>>>> exposed to few applications.
>>>>>
>>>>> It makes it impossible to take the address of the function, though.
>>>>
>>>> It does.  Do you have a better suggestion to achieve the same effect?
>>>
>>> If getrandom is ever standardized be POSIX this will have to be reverted
>>> anyway.
>>
>> So you don't object to this approach?
>
> Not providing a getrandom symbol is a bug.

Is this better?

Thanks,
Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: getrandom-wrapper-only.patch
Type: text/x-patch
Size: 30234 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160908/7f0b4fab/attachment.bin>