[PATCH v2] Add getrandom implementation [BZ #17252]

Florian Weimer fweimer@redhat.com
Thu Sep 8 10:28:00 GMT 2016


On 09/08/2016 12:12 PM, Andreas Schwab wrote:

>> +      if (!((flags & GRND_RANDOM)
>> +            && (flags & GRND_NONBLOCK)
>
> Please add != 0 (no implicit boolean coercion).

The wiki says this is okay (search for “foo & BIT”):

   <https://sourceware.org/glibc/wiki/Style_and_Conventions>

Thanks,
Florian



More information about the Libc-alpha mailing list