[PATCH] struct stat: don't typecast to struct kernel_stat were not needed

Yury Norov ynorov@caviumnetworks.com
Tue Sep 6 16:27:00 GMT 2016


On Tue, Sep 06, 2016 at 12:19:12PM -0400, Chris Metcalf wrote:
> On 9/6/2016 7:28 AM, Yury Norov wrote:
> >The cast comes from the beginning of the git history, and probably was needed
> >when macro CHECK1() was used in syscalls. Now the cast is looking useless, and
> >breaks build if struct kernel_stat is not declared.
> >
> >	* sysdeps/unix/sysv/linux/fxstat.c: Remove useless cast.
> >	* sysdeps/unix/sysv/linux/lxstat.c: Likewise.
> >	* sysdeps/unix/sysv/linux/xstat.c: Likewise.
> >	* sysdeps/unix/sysv/linux/i386/fxstat.c: Likewise.
> >	* sysdeps/unix/sysv/linux/i386/lxstat.c: Likewise.
> >	* sysdeps/unix/sysv/linux/i386/xstat.c: Likewise.
> >
> >Signed-off-by: Yury Norov<ynorov@caviumnetworks.com>
> 
> I think you mean "where not needed" in the commit subject.

Yes. Should I resend it?



More information about the Libc-alpha mailing list