[PATCH v3] Fix -Os related build and test failures.

[Steve Ellcey]

Carlos,

I am running into a build problem with your patch. Â weight.h uses the
DIAG_* macros but does not include libc-internal.h, where those macros
are defined. Â Apparently it assuming whatever file includes it will
include libc-internal.h.

That is not happening for me when I compile
string/strxfrm_l.c, posix/fnmatch.c, and posix/regex.c.  regex.c does
not include weight.h itself but includes regex_internal.h which
includes weight.h). Â I think there are more files with this problem
too, I haven't finished my build yet.

I am building on an aarch64 machine with a prerelease version of GCC
7.0, I think the compiler I am using may be why other people are not
seeing this error.

I am not sure if weight.h should include libc-internal.h, since that is
what uses it, or if the .c and .h files that include weight.h should
also have include libc-internal.h.

Steve Ellcey
sellcey@caviumnetworks.com