[PATCH v2] Fix warning caused by unused-result in bug-atexit3-lib.cc
Gabriel F. T. Gomes
gftg@linux.vnet.ibm.com
Fri Oct 28 17:58:00 GMT 2016
Changes since v1:
- Copy write_message from test-skeleton.c to dlfcn/bug-atexit3-lib.cc.
- Replace calls to write with calls to write_message.
---8<---
The test case dlfcn/bug-atexit3-lib.cc calls write and doesn't check the
result. When building with GCC 6.2, this generates a warning in 'make
check', which is treated as an error. This patch replaces the call to
write with a call to write_message.
Tested for powerpc64le.
2016-10-28 Gabriel F. T. Gomes <gftg@linux.vnet.ibm.com>
* dlfcn/bug-atexit3-lib.cc (write_message): New function, copied
from test-skeleton.c.
(statclass): Replace calls to write with calls to write_message.
---
dlfcn/bug-atexit3-lib.cc | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git a/dlfcn/bug-atexit3-lib.cc b/dlfcn/bug-atexit3-lib.cc
index 3d01ea8..aba7720 100644
--- a/dlfcn/bug-atexit3-lib.cc
+++ b/dlfcn/bug-atexit3-lib.cc
@@ -1,14 +1,22 @@
#include <unistd.h>
+#include <string.h>
+
+static void
+write_message (const char *message)
+{
+ ssize_t unused __attribute__ ((unused));
+ unused = write (STDOUT_FILENO, message, strlen (message));
+}
struct statclass
{
statclass()
{
- write (1, "statclass\n", 10);
+ write_message ("statclass\n");
}
~statclass()
{
- write (1, "~statclass\n", 11);
+ write_message ("~statclass\n");
}
};
--
2.4.11
More information about the Libc-alpha
mailing list