[PATCH] crypt: Use internal names for the SHA-2 block functions

Joseph Myers joseph@codesourcery.com
Fri Oct 28 17:09:00 GMT 2016


On Fri, 28 Oct 2016, Adhemerval Zanella wrote:

> It should __sha256_process_block_generic here.  Also, if we now aiming
> for namespace clean shouldn't we also add a conform test for crypt.h
> header?

crypt.h is not in any standard supported by the conform tests.

It's true that linknamespace considerations apply even for _DEFAULT_SOURCE 
and _GNU_SOURCE - using a function declared under one of those conditions 
should not bring in a reference to a function not so declared.  The 
difficulty in testing this is that it really needs a list of all installed 
headers to be visible in one place (and there's the question of whether we 
consider _DEFAULT_SOURCE to include all headers or not).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list