[PATCH] Initialise the machine specific part of rtld bootstrap map

Joseph Myers joseph@codesourcery.com
Wed Oct 26 20:12:00 GMT 2016


On Wed, 26 Oct 2016, Matthew Fortune wrote:

> +# ifdef ELF_MACHINE_INIT_MAP
> +  ELF_MACHINE_INIT_MAP (bootstrap_map);
> +# endif

We don't encourage use of #ifdef like that.  It's better to have an inline 
function defined everywhere and used unconditionally, for which most 
systems have a dummy definition (see dl-machine-reject-phdr.h and 
elf_machine_reject_phdr_p for an example - if you have a header for a 
single function, you don't need to update lots of dl-machine.h headers, 
just add a generic version - which has the comments detailing the 
semantics of the function and when it's needed - and a MIPS version).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list