[PATCH] Define iszero as a function template for C++ [BZ #20715]

Florian Weimer fweimer@redhat.com
Sat Oct 22 15:35:00 GMT 2016


On 10/21/2016 06:31 PM, Florian Weimer wrote:
> On 10/21/2016 06:23 PM, Joseph Myers wrote:
>> On Fri, 21 Oct 2016, Florian Weimer wrote:
>>
>>> On 10/21/2016 06:12 PM, Joseph Myers wrote:
>>>> On Fri, 21 Oct 2016, Florian Weimer wrote:
>>>>
>>>>> Tested on x86_64, ppc64, ppc64le, s390x, aarch64.
>>>>>
>>>>> I'm not sure if the new test is particularly meaningful, but at
>>>>> least it
>>>>> catches syntax errors in <math.h>.
>>>>
>>>> This seems fine to me (with negative zero included in the testcase),
>>>
>>> Oh.  How do I get a negative zero?  Would T{-0.0} be sufficient?  Or
>>> should I
>>
>> Yes, T{-0.0} or -T{0} should suffice.
>
> Thanks.  Here is what I've committed.  Everything is optimized away
> anyway (but I deliberately introduced a bug to make sure the test still
> tests something).

I had to commit the attached follow-on fix to make

extern "C" {
#include <math.h>
}

work again.

Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: iszero2.patch
Type: text/x-patch
Size: 932 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20161022/048325d3/attachment.bin>


More information about the Libc-alpha mailing list