As far as I'm concerned, patches 1 and 2 are OK at this point, but shouldn't go in until the testcases have also passed review. -- Joseph S. Myers joseph@codesourcery.com